DurationFormatter: Duration Formatter Digital Implementation #5263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younies
reviewed
Jul 18, 2024
kartva
force-pushed
the
duration-formatter-digital-impl
branch
3 times, most recently
from
585c79b to
6cb98f9
Compare
kartva
commented
Jul 30, 2024
younies
reviewed
Jul 30, 2024
younies
approved these changes
Jul 30, 2024
sffc
previously approved these changes
Jul 30, 2024
|
Filed #5319 for fixed_decimal bug fix, and reverted the change in this PR. |
and add testdata
add documentation to hour and minute format
previously using incorrect function to set maximum fractional digits
kartva
force-pushed
the
duration-formatter-digital-impl
branch
from
3225183 to
9d6cb8b
Compare
younies
reviewed
Jul 31, 2024
Comment on lines
+75
to
+83
| impl DurationSign { | ||
| pub(crate) fn as_fixed_decimal_sign(&self) -> fixed_decimal::Sign { | ||
| match self { | ||
| DurationSign::Positive => fixed_decimal::Sign::Positive, | ||
| DurationSign::Negative => fixed_decimal::Sign::Negative, | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
in a following PR:
Suggested change
| impl DurationSign { | |
| pub(crate) fn as_fixed_decimal_sign(&self) -> fixed_decimal::Sign { | |
| match self { | |
| DurationSign::Positive => fixed_decimal::Sign::Positive, | |
| DurationSign::Negative => fixed_decimal::Sign::Negative, | |
| } | |
| } | |
| } | |
| impl As<fixed_decimal::Sign> for DurationSign { | |
| fn as(&self) -> Sign { | |
| match self { | |
| DurationSign::Positive => fixed_decimal::Sign::Positive, | |
| DurationSign::Negative => fixed_decimal::Sign::Negative, | |
| } | |
| } | |
| } | |
younies
approved these changes
Jul 31, 2024
sffc
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on merging #5208